This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH][BZ #13724] Do not segfault in pthread_setname_np (x, NULL)
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Torvald Riegel <triegel at redhat dot com>
- Cc: Andreas Schwab <schwab at suse dot de>, Rich Felker <dalias at aerifal dot cx>, OndÅej BÃlka <neleai at seznam dot cz>, libc-alpha at sourceware dot org
- Date: Tue, 08 Oct 2013 17:40:29 -0400
- Subject: Re: [PATCH][BZ #13724] Do not segfault in pthread_setname_np (x, NULL)
- Authentication-results: sourceware.org; auth=none
- References: <20131003122009 dot GA8891 at domone dot podge> <524DCA52 dot 2030609 at redhat dot com> <20131007141928 dot GV20515 at brightrain dot aerifal dot cx> <52542C63 dot 10305 at redhat dot com> <mvmr4bvww2y dot fsf at hawking dot suse dot de> <5254586D dot 50501 at redhat dot com> <1381266054 dot 18547 dot 1106 dot camel at triegel dot csb>
On 10/08/2013 05:00 PM, Torvald Riegel wrote:
>> I've documented what I understand is our practice for assert:
>> Assertions are for internal consistency checking only.
>> External conditions are governed by the API and if user
>> code violates the API then the library behaviour is undefined.
>> However, in scenarios where user input is recorded into
>> internal structures for later use it is useful to assert
>> in these cases to catch the first occurrence of the error.
> Perhaps it's useful to distinguish between asserts (ie, the internal
> consistency checks) and checks that test whether callers adhere to the
> preconditions required by a function?
What would you say?