This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] stdlib/tst-qsort2.c: Fix off-by-one argc interpretation error


 This fixes an off-by-one argc interpretation error (argv[0] is included 
in the count) in stdlib/tst-qsort2.c causing a segfault if the program is 
called with one command-line argument only (argv[2] is NULL in that case).  

 The issue doesn't trigger in regular testing as the test case is invoked 
without arguments in the test suite, but that doesn't mean the bug is good 
to have.  OK to apply?

2013-10-04  Maciej W. Rozycki  <>

	* stdlib/tst-qsort2.c (main): Fix off-by-one argc interpretation 


Index: glibc-fsf-trunk-quilt/stdlib/tst-qsort2.c
--- glibc-fsf-trunk-quilt.orig/stdlib/tst-qsort2.c	2012-11-21 23:51:44.000000000 +0000
+++ glibc-fsf-trunk-quilt/stdlib/tst-qsort2.c	2013-10-04 16:04:38.369106557 +0100
@@ -70,7 +70,7 @@ int
 main (int argc, char **argv)
   int ret = 0;
-  if (argc >= 2)
+  if (argc >= 3)
     ret |= test (atoi (argv[1]), atoi (argv[2]));

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]