This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 10/01/2013 04:14 PM, Roland McGrath wrote: > It should be easy enough to write a regression test for this using a > locally defined free. So I think you don't get any exemption from the > usual policy of regression tests for user-visible bug fixes. :-) Any pointers to an existing test in the regression suite that does this for other interfaces, to give me a leg up on attempting that? I'm not very familiar with the glibc testsuite yet (this whole thread is the result of someone FINALLY reviewing a BZ that has sat with a patch but unreviewed in the glibc database for more than 3 years, stemming from gnulib patching their source code for the same issue way back then). > > Also, "saved_errno" is the variable name usually used for saving and > restoring errno so as not to touch it. It would be more clear to name it > something like "failure_errno". Sure, easy enough to do. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |