This is the mail archive of the
mailing list for the glibc project.
Re: [PATCHv2 2/2] realpath: don't lose errno on failure
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Eric Blake <eblake at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 1 Oct 2013 15:14:35 -0700 (PDT)
- Subject: Re: [PATCHv2 2/2] realpath: don't lose errno on failure
- Authentication-results: sourceware.org; auth=none
- References: <1380658974-28848-1-git-send-email-eblake at redhat dot com> <1380658974-28848-3-git-send-email-eblake at redhat dot com>
It should be easy enough to write a regression test for this using a
locally defined free. So I think you don't get any exemption from the
usual policy of regression tests for user-visible bug fixes. :-)
Also, "saved_errno" is the variable name usually used for saving and
restoring errno so as not to touch it. It would be more clear to name it
something like "failure_errno".