This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: locale files and int32_t alignment
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: Andreas Schwab <schwab at suse dot de>, <libc-alpha at sourceware dot org>
- Date: Mon, 23 Sep 2013 16:16:09 -0700 (PDT)
- Subject: Re: locale files and int32_t alignment
- Authentication-results: sourceware.org; auth=none
- References: <Pine dot LNX dot 4 dot 64 dot 1309040055321 dot 27960 at digraph dot polyomino dot org dot uk> <mvmli324c48 dot fsf at hawking dot suse dot de> <Pine dot LNX dot 4 dot 64 dot 1309122107200 dot 28584 at digraph dot polyomino dot org dot uk>
I think the change is good in principle. But it should be more explicit in
the code. A few macros (e.g. LOCFILE_ALIGN, LOCFILE_ALIGNED_P (x)) instead
of just sizeof (int32_t) all over would serve as adequate implicit
documentation.
Thanks,
Roland