This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RFC][PATCH] (Elision) Rename retry_try_xbegin to try_xbegin
- From: Torvald Riegel <triegel at redhat dot com>
- To: libc-alpha at sourceware dot org
- Cc: andi at firstfloor dot org
- Date: Fri, 20 Sep 2013 15:10:14 +0200
- Subject: Re: [RFC][PATCH] (Elision) Rename retry_try_xbegin to try_xbegin
- Authentication-results: sourceware.org; auth=none
- References: <20130918113639 dot GA8139 at linux dot vnet dot ibm dot com>
On Wed, 2013-09-18 at 13:36 +0200, Dominik Vogt wrote:
> The attached patch renames retry_try_xbegin in the elision_config
> structure to try_xbegin and fixes the source code documentation.
> It is actually not the number of _re_tries but the total number of
> attempts using elision before using the lock. The docuementation
> suggested that (with the default values) one attempt plus three
> retries would be made while in reality it were only three attempts
> in total.
This looks fine to me, provided you at least have built an x86-64 glibc
with elision enabled.
However, I think the changelog should first state the change for
elision-conf.h, and then use "...elision-conf.c: Likewise." for the
other two files.
2013-09-18 Dominik Vogt <vogt@linux.vnet.ibm.com>
* sysdeps/unix/sysv/linux/x86/elision-lock.c
(__lll_lock_elision):
* sysdeps/unix/sysv/linux/x86/elision-conf.c:
* sysdeps/unix/sysv/linux/x86/elision-conf.h (struct
elision_config):
Rename elision_config.retry_try_xbegin to try_xbegin