Re: [ping][BZ #15963, 15608, 15609, 15610, 15681] New language codes and locales

[Chris Leonard <cjlhomeaddress at gmail dot com>]

Committed with suggested changes.

I was able to close the tickets myself.

cjl

On Thu, Sep 19, 2013 at 11:46 PM, Carlos O'Donell <carlos@redhat.com> wrote:
> On 09/19/2013 08:41 PM, Chris Leonard wrote:
>> I've formatted a patch to address [BZ #15963] and added in [BZ#13985]
>> for good measure.
>>
>> Did I get the Changelog format correct (for covering two tickets)?
>
> Not quite, see my comments below. It takes a while to get the style
> right and the level of detail. Like anything it gets easier with
> practice.

>> Any objections to this landing?
>
> I do not object. The patch looks good to me.
>
>> If I do land it, can someone please close the relevant tickets?
>
> Have you tried closing the ticket yourself? I can help you there
> if you have any permission problems.
>
> I suggest updating the ticket with the commit id as a comment
> and closing it fixed.
>
> e.g.
>
> Fixed by commit <commit id hash>
>
>> /Changelog
>>
>> 2013-09-18  Wei-Lun Chao  <bluebat@member.fsf.org>
>>
>>     [BZ #15963]
>>     * locale/iso-639.def: Add Chinese language codes to iso-639.def.
>>
>>     [BZ#13985]
>>     * locale/iso-639.def: Add Chiga language code to iso-639.def.
>
> That is not sufficiently detailed, nor does it express what you added
> and the fact that nan wasn't added but had the name changes.
>
> I would use:
>
>         [BZ #15963, #13985]
>         * locale/iso-639.def: Add Chiga (cgg) and Chinese (gan, hak,
>         czh, cjy, lzh, cmn, mnp, cdo, czo, cpx, wuu, hsn, yue).
>         Add `Chinese' to `nan' entry name.
>
> Note that the subject line references *several* BZs, all of which
> need be in the ChangeLog BZ line if this patch fixes those BZs and
> if you plan to close them all.
>
> Also the NEWS entry needs updating with the fixed BZ's, see:
> https://sourceware.org/glibc/wiki/Committer%20checklist
>
> I happy to see these kinds of issues getting fixed! :-)
>
> Thank you!
>
>> ---
>>  locale/iso-639.def | 16 +++++++++++++++-
>>  1 file changed, 15 insertions(+), 1 deletion(-)
>>
>> diff --git a/locale/iso-639.def b/locale/iso-639.def
>> index 50b5a52..8bac952 100644
>> --- a/locale/iso-639.def
>> +++ b/locale/iso-639.def
>> @@ -95,6 +95,7 @@ DEFINE_LANGUAGE_CODE3 ("Cheyenne", chy, chy)
>>  DEFINE_LANGUAGE_CODE2 ("Chhattisgarhi", hne)    /* ISO 639-3 */
>>  DEFINE_LANGUAGE_CODE3 ("Chibcha", chb, chb)
>>  DEFINE_LANGUAGE_CODE ("Chichewa; Chewa; Nyanja", ny, nya, nya)
>> +DEFINE_LANGUAGE_CODE3 ("Chiga", cgg, cgg)
>>  DEFINE_LANGUAGE_CODE ("Chinese", zh, zho, chi)
>>  DEFINE_LANGUAGE_CODE3 ("Chinook jargon", chn, chn)
>>  DEFINE_LANGUAGE_CODE3 ("Chipewyan", chp, chp)
>> @@ -161,6 +162,7 @@ DEFINE_LANGUAGE_CODE3 ("Friulian", fur, fur)
>>  DEFINE_LANGUAGE_CODE ("Fulah", ff, ful, ful)
>>  DEFINE_LANGUAGE_CODE ("Gaelic; Scottish Gaelic", gd, gla, gla)
>>  DEFINE_LANGUAGE_CODE ("Galician", gl, glg, glg)
>> +DEFINE_LANGUAGE_CODE3 ("Gan Chinese", gan, gan)
>>  DEFINE_LANGUAGE_CODE ("Ganda", lg, lug, lug)
>>  DEFINE_LANGUAGE_CODE3 ("Gayo", gay, gay)
>>  DEFINE_LANGUAGE_CODE3 ("Ga", gaa, gaa)
>> @@ -184,6 +186,7 @@ DEFINE_LANGUAGE_CODE ("Gujarati", gu, guj, guj)
>>  DEFINE_LANGUAGE_CODE3 ("Gwich´in", gwi, gwi)
>>  DEFINE_LANGUAGE_CODE3 ("Haida", hai, hai)
>>  DEFINE_LANGUAGE_CODE ("Haitian; Haitian Creole", ht, hat, hat)
>> +DEFINE_LANGUAGE_CODE3 ("Hakka Chinese", hak, hak)
>>  DEFINE_LANGUAGE_CODE ("Hausa", ha, hau, hau)
>>  DEFINE_LANGUAGE_CODE3 ("Hawaiian", haw, haw)
>>  DEFINE_LANGUAGE_CODE ("Hebrew", he, heb, heb)
>> @@ -194,6 +197,7 @@ DEFINE_LANGUAGE_CODE ("Hindi", hi, hin, hin)
>>  DEFINE_LANGUAGE_CODE ("Hiri Motu", ho, hmo, hmo)
>>  DEFINE_LANGUAGE_CODE3 ("Hittite", hit, hit)
>>  DEFINE_LANGUAGE_CODE3 ("Hmong", hmn, hmn)
>> +DEFINE_LANGUAGE_CODE3 ("Huizhou Chinese", czh, czh)
>>  DEFINE_LANGUAGE_CODE ("Hungarian", hu, hun, hun)
>>  DEFINE_LANGUAGE_CODE3 ("Hupa", hup, hup)
>>  DEFINE_LANGUAGE_CODE3 ("Iban", iba, iba)
>> @@ -219,6 +223,7 @@ DEFINE_LANGUAGE_CODE3 ("Iroquoian languages", iro, iro)
>>  DEFINE_LANGUAGE_CODE ("Italian", it, ita, ita)
>>  DEFINE_LANGUAGE_CODE ("Japanese", ja, jpn, jpn)
>>  DEFINE_LANGUAGE_CODE ("Javanese", jv, jav, jav)
>> +DEFINE_LANGUAGE_CODE3 ("Jinyu Chinese", cjy, cjy)
>>  DEFINE_LANGUAGE_CODE3 ("Judeo-Arabic", jrb, jrb)
>>  DEFINE_LANGUAGE_CODE3 ("Judeo-Persian", jpr, jpr)
>>  DEFINE_LANGUAGE_CODE3 ("Kabardian", kbd, kbd)
>> @@ -267,6 +272,7 @@ DEFINE_LANGUAGE_CODE ("Latvian", lv, lav, lav)
>>  DEFINE_LANGUAGE_CODE3 ("Lezghian", lez, lez)
>>  DEFINE_LANGUAGE_CODE ("Limburgan; Limburger; Limburgish", li, lim, lim)
>>  DEFINE_LANGUAGE_CODE ("Lingala", ln, lin, lin)
>> +DEFINE_LANGUAGE_CODE3 ("Literary Chinese", lzh, lzh)
>>  DEFINE_LANGUAGE_CODE ("Lithuanian", lt, lit, lit)
>>  DEFINE_LANGUAGE_CODE3 ("Lojban", jbo, jbo)
>>  DEFINE_LANGUAGE_CODE3 ("Low German; Low Saxon; German, Low; Saxon,
>> Low", nds, nds)
>> @@ -290,6 +296,7 @@ DEFINE_LANGUAGE_CODE ("Malayalam", ml, mal, mal)
>>  DEFINE_LANGUAGE_CODE ("Malay", ms, msa, may)
>>  DEFINE_LANGUAGE_CODE ("Maltese", mt, mlt, mlt)
>>  DEFINE_LANGUAGE_CODE3 ("Manchu", mnc, mnc)
>> +DEFINE_LANGUAGE_CODE3 ("Mandarin Chinese", cmn, cmn)
>>  DEFINE_LANGUAGE_CODE3 ("Mandar", mdr, mdr)
>>  DEFINE_LANGUAGE_CODE3 ("Mandingo", man, man)
>>  DEFINE_LANGUAGE_CODE3 ("Manipuri", mni, mni)
>> @@ -305,7 +312,10 @@ DEFINE_LANGUAGE_CODE3 ("Mayan languages", myn, myn)
>>  DEFINE_LANGUAGE_CODE3 ("Mende", men, men)
>>  DEFINE_LANGUAGE_CODE3 ("Mi'kmaq; Micmac", mic, mic)
>>  DEFINE_LANGUAGE_CODE3 ("Minangkabau", min, min)
>> -DEFINE_LANGUAGE_CODE3 ("Min Nan", nan, nan)
>> +DEFINE_LANGUAGE_CODE3 ("Min Bei Chinese", mnp, mnp)
>> +DEFINE_LANGUAGE_CODE3 ("Min Dong Chinese", cdo, cdo)
>> +DEFINE_LANGUAGE_CODE3 ("Min Nan Chinese", nan, nan)
>> +DEFINE_LANGUAGE_CODE3 ("Min Zhong Chinese", czo, czo)
>>  DEFINE_LANGUAGE_CODE3 ("Mirandese", mwl, mwl)
>>  DEFINE_LANGUAGE_CODE3 ("Miscellaneous languages", mis, mis)
>>  DEFINE_LANGUAGE_CODE3 ("Mohawk", moh, moh)
>> @@ -369,6 +379,7 @@ DEFINE_LANGUAGE_CODE ("Polish", pl, pol, pol)
>>  DEFINE_LANGUAGE_CODE ("Portuguese", pt, por, por)
>>  DEFINE_LANGUAGE_CODE3 ("Prakrit languages", pra, pra)
>>  DEFINE_LANGUAGE_CODE3 ("Provençal, Old (to 1500)", pro, pro)
>> +DEFINE_LANGUAGE_CODE3 ("Pu-Xian Chinese", cpx, cpx)
>>  DEFINE_LANGUAGE_CODE ("Pushto", ps, pus, pus)
>>  DEFINE_LANGUAGE_CODE ("Quechua", qu, que, que)
>>  DEFINE_LANGUAGE_CODE ("Raeto-Romance", rm, roh, roh)
>> @@ -486,12 +497,15 @@ DEFINE_LANGUAGE_CODE3 ("Waray", war, war)
>>  DEFINE_LANGUAGE_CODE3 ("Washo", was, was)
>>  DEFINE_LANGUAGE_CODE ("Welsh", cy, cym, wel)
>>  DEFINE_LANGUAGE_CODE ("Wolof", wo, wol, wol)
>> +DEFINE_LANGUAGE_CODE3 ("Wu Chinese", wuu, wuu)
>>  DEFINE_LANGUAGE_CODE ("Xhosa", xh, xho, xho)
>> +DEFINE_LANGUAGE_CODE3 ("Xiang Chinese", hsn, hsn)
>>  DEFINE_LANGUAGE_CODE3 ("Yakut", sah, sah)
>>  DEFINE_LANGUAGE_CODE3 ("Yao", yao, yao)
>>  DEFINE_LANGUAGE_CODE3 ("Yapese", yap, yap)
>>  DEFINE_LANGUAGE_CODE ("Yiddish", yi, yid, yid)
>>  DEFINE_LANGUAGE_CODE ("Yoruba", yo, yor, yor)
>> +DEFINE_LANGUAGE_CODE3 ("Yue Chinese", yue, yue)
>>  DEFINE_LANGUAGE_CODE3 ("Yupik languages", ypk, ypk)
>>  DEFINE_LANGUAGE_CODE3 ("Zande", znd, znd)
>>  DEFINE_LANGUAGE_CODE3 ("Zapotec", zap, zap)
>
> Cheers,
> Carlos.