This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Potential issue with strstr on x86 with sse4.2 in glibc-2.18

On Mon, Aug 19, 2013 at 07:54:22PM +0400, Alexander Monakov wrote:
> On Mon, 19 Aug 2013, Rich Felker wrote:
> > Really this doesn't even look like a case of a legacy binary, but
> > rather fglrx's simply containing incorrect asm (or just
> > CFLAGS?) that doesn't match the modern psABI calling convention. It
> > would probably be best to pressure its maintainers to fix this bug on
> > their side...
> I'm afraid what's more likely to happen in practice is distributions being
> pressured by users to pick up the patch reinstating the inline keywords in
> strstr.c.  Allan, what are you going to do in Arch Linux about this?  Keep
> patching upstream, or drop the patch, let FGLRX break and tell users to
> complain to AMD, or... ?  [I do realize that the two former options are bad]

As far as I can tell, adding the inline keywords back is not a fix,
it's just a perturbation of gcc's behavior that happens to re-mask the
bug. It could really come back at any time depending on compiler
version, CFLAGS, etc.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]