Re: [PATCH] Fix multi-arch build with elision

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Wed, Jul 3, 2013 at 9:18 AM, Carlos O'Donell <carlos@redhat.com> wrote:
> On 07/03/2013 11:37 AM, H.J. Lu wrote:
>> On Wed, Jul 3, 2013 at 8:30 AM, Andi Kleen <andi@firstfloor.org> wrote:
>>> On Wed, Jul 03, 2013 at 08:21:53AM -0700, H.J. Lu wrote:
>>>> On Tue, Jul 2, 2013 at 11:21 PM, Markus Trippelsdorf
>>>> <markus@trippelsdorf.de> wrote:
>>>>> On 2013.07.02 at 14:57 -0700, Andi Kleen wrote:
>>>>>> From: Andi Kleen <ak@linux.intel.com>
>>>>>>
>>>>>> This is the simplest fix I could come up with for Markus'
>>>>>> no multiarch problem. Markus can you test please?
>>>>>
>>>>> Yes, it works fine. Thanks Andi.
>>>>>
>>>>> --
>>>>> Markus
>>>>
>>>> Try this.
>>>
>>> I considered something similar first, but it would also need the same for
>>> the glibc Versions file at least, to export __get_cpu_features
>>> from the main glibc to pthread, right? Or would pthread use its own
>>> version?
>>>
>>
>> I think init-arch.o is duplicated in libc.so and libpthread.so.
>
> That is correct.
>
> The nptl version is identical to the libc version.
>
> Your patch resolves the build issue when building with
> --disable-multi-arch (on an otherwise multi-arch setup).

I checked my patch in.

> Please check this in ASAP and CC David Miller as the
> release manager. Provide a short explanation of the
> build failure fix.
>

init-arch isn''t available in nptl when --disable-multi-arch
is used. My fix is to provide it in nptl directly, independent
of multiarch.

--
H.J.