This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Don't use SSE4_2 instructions on Intel Silvermont Micro Architecture.\


On 1 July 2013 01:56, Carlos O'Donell <carlos@redhat.com> wrote:
>> 1. You use only 32 element sample. Can you be sure that this sample is
>> big enough to be relevant?
>>
>> 2. You take minimum of these samples. Please explain how this is related
>> to real performance.
>>
>> 3. You call this code in loop with same argmuments. Please explain why
>> real world usage cases are close enough that we can observe same
>> behaviour in real world.

Please refer to the archives for answers to those questions.

>> Unless you can satisfactory answer these questions you did not prove
>> anything about performance only got some numbers that are loosely
>> related to it.
>
> Thanks for the review. Could you please start a new thread and CC
> Siddhehs whose the most well versed in this code? Your questions
> are valid questions, and I hope that their discussion leads to a
> better microbenchmark.

These discussions have happened earlier and we have simply been going
around in circles with it.  I don't see any point in continuing this
discussion without any constructive code to move the discussion
forward.  I will work on improving the string benchmarks in the 2.19
cycle and we can then discuss those patches.

Siddhesh
--
http://siddhesh.in


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]