This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: requiring text format for patch attachments?
- From: Chris Metcalf <cmetcalf at tilera dot com>
- To: Carlos O'Donell <carlos at systemhalted dot org>
- Cc: GLIBC Devel <libc-alpha at sourceware dot org>
- Date: Fri, 28 Jun 2013 15:19:26 -0400
- Subject: Re: requiring text format for patch attachments?
- References: <CABXK9nfhHHnm+4LLnrtW-=Py69WvwcF3BWt-kf-TNHsPvqa5ig at mail dot gmail dot com> <51CD9D3B dot 8090002 at tilera dot com> <51CDDD8D dot 9010104 at systemhalted dot org>
On 6/28/2013 3:01 PM, Carlos O'Donell wrote:
> On 06/28/2013 10:27 AM, Chris Metcalf wrote:
>> I did double-check the wiki contribution
>> checklist to confirm it says "patches inline or as attachments", so
>> from that point of view we seem to be OK.
> If we want to support patches as attachments please send an email
> to libc-alpha and ask for consensus around that, then document it
> in the contribution checklist.
Attachments are already supported per the contribution checklist (quoted below). It might be useful to mention something about attachments being helpful to avoid whitespace damage too, in addition to wrapping damage.
> 13. Proper Formatted Unified diff of the Changes
>
> - Only unified diff (-uNr) format is acceptable. Patches which are context diffs will not be reviewed.
> - Unified diff must be in a format that can be applied with patch -p1.
> - Included inline with the text of the email or as a separate attachment if your mailer wraps long lines.
>
> If you have any questions regarding these criteria please email libc-help@sourceware.org .
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com