This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [COMMITTED] Fix build for locale/programs/locarchive.c
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Richard Henderson <rth at twiddle dot net>
- Cc: libc-alpha <libc-alpha at sourceware dot org>, Mike Frysinger <vapier at gentoo dot org>
- Date: Tue, 25 Jun 2013 16:04:55 -0400
- Subject: Re: [COMMITTED] Fix build for locale/programs/locarchive.c
- References: <51C9E0AE dot 1030405 at twiddle dot net>
On 06/25/2013 02:25 PM, Richard Henderson wrote:
> Mike's two recent commits,
>
> d605071ebf1fbbba5998a349540d4ad4e667f65e
>
> introduce the PTR_ALIGN_UP macro
>
> 17db6e8d6b12f55e312fcab46faf5d332c806fb6
>
> and use the macro, but the later doesn't ensure that the correct
> header is actually included. I can't say whether I noticed that
> this failed on x86_64, but it did for Alpha. Perhaps there's a
> different set of implicit includes going on, but I didn't try to
> really figure it out.
>
> Committed as obvious.
It does not fail for x86-64 because libc-internal.h is included
via tls.h.
Cheers,
Carlos.