This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Polished patch (crash after pthread_exit)
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Andreas Jaeger <aj at suse dot com>
- Cc: Vladimir Nikulichev <v dot nikulichev at gmail dot com>, libc-alpha at sourceware dot org
- Date: Mon, 24 Jun 2013 15:42:26 -0400
- Subject: Re: [PATCH] Polished patch (crash after pthread_exit)
- References: <CAKt5dD1-XUyCSdhys+J5NJbCYQTMunwpcmECvRm1F0VSR4Jh+w at mail dot gmail dot com> <51C89EEB dot 3030604 at suse dot com>
On 06/24/2013 03:32 PM, Andreas Jaeger wrote:
> On 06/24/2013 09:01 PM, Vladimir Nikulichev wrote:
>> http://sourceware.org/bugzilla/show_bug.cgi?id=12310
>>
>> diff --git nptl/ChangeLog nptl/ChangeLog
>> index 0e3b018..03a7d5d 100644
>> --- nptl/ChangeLog
>> +++ nptl/ChangeLog
>> @@ -1,3 +1,7 @@
>> +2013-06-23 Vladimir Nikulichev <v.nikulichev@gmail.com>
>> +
>> + * pthread_exit.c: Add reference to pthread_create()
>> +
>
> We normally do not send ChangeLogs as diff, just the plain text. For
> details see
> http://sourceware.org/glibc/wiki/Contribution%20checklist
>
> also, it should mention the bugzilla number - and a sentence ends
> with a "."
>
>> 2013-06-15 Siddhesh Poyarekar <siddhesh@redhat.com>
>>
>> * Versions (libpthread): Add GLIBC_2.18.
>> diff --git nptl/pthread_exit.c nptl/pthread_exit.c
>> index 3718081..33ba767 100644
>> --- nptl/pthread_exit.c
>> +++ nptl/pthread_exit.c
>> @@ -29,3 +29,7 @@ __pthread_exit (value)
>> __do_cancel ();
>> }
>> strong_alias (__pthread_exit, pthread_exit)
>> +
>> +/* After a thread terminates, __libc_start_main() decrements
>> + __nptl_nthreads defined in pthread_create.c */
>
> This is a sentence, so end it with "." followed by two spaces.
>
>> +PTHREAD_STATIC_FN_REQUIRE (pthread_create)
>>
>
> Carlos, could you commit this after testing with the above changes
> (including updating NEWS) on behalf of Vladimir?
Certainly.
I'm doing a build right now.
I just wanted to confirm a few more details.
Cheers,
Carlos.