This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/5][v2][BZ #15022] Avoid repeated calls to DL_STATIC_INIT
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 21 Jun 2013 11:11:19 -0700 (PDT)
- Subject: Re: [PATCH 1/5][v2][BZ #15022] Avoid repeated calls to DL_STATIC_INIT
- References: <alpine dot DEB dot 1 dot 10 dot 1301152056590 dot 4834 at tp dot orcam dot me dot uk> <20130116215545 dot 7A37A2C0B0 at topped-with-meat dot com> <alpine dot DEB dot 1 dot 10 dot 1301240655220 dot 4834 at tp dot orcam dot me dot uk> <20130531200059 dot C94C02C077 at topped-with-meat dot com> <alpine dot DEB dot 1 dot 10 dot 1306140202520 dot 16287 at tp dot orcam dot me dot uk> <20130619233103 dot A913F2C0A6 at topped-with-meat dot com> <CAMe9rOpR6OGW6CfrG5NN2HPM_=tW-1om4Y_dFVXmUk2h5xg6sQ at mail dot gmail dot com> <20130620204740 dot 69A5E2C135 at topped-with-meat dot com> <alpine dot DEB dot 1 dot 10 dot 1306211348160 dot 16287 at tp dot orcam dot me dot uk>
I concur with your analysis. (I was considering the relationship of the
two locks when responding to HJ earlier, but failed to be clear about it.)
I think it's wise to make the removal of the extraneous lock a separate
follow-up change, just for paranoia's sake (i.e. ease of reversion if
needed for some unforeseen reason).
The issue of the internal lock held while calling user initializers is
entirely separate. It has concerned me before when I've noticed it in
passing, but I never dawdled long enough to bring it up for discussion. I
think you should file a bug about that one and we'll consider it separately
later. But that will clearly have to be after the impending freeze.
Thanks,
Roland