This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix leading whitespace.
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 6 Jun 2013 02:24:27 +0200
- Subject: Re: [PATCH] Fix leading whitespace.
- References: <20130605230815 dot GA6738 at domone dot kolej dot mff dot cuni dot cz> <Pine dot LNX dot 4 dot 64 dot 1306052125240 dot 7769 at digraph dot polyomino dot org dot uk>
On Wed, Jun 05, 2013 at 09:33:23PM +0000, Joseph S. Myers wrote:
> On Thu, 6 Jun 2013, wizard wrote:
>
> > It also found that posix/transbug.c is executable
> > mode change 100755 => 100644 posix/transbug.c
>
> A mode change should be a separate commit (I consider that fix obvious).
>
> > It is 675kb file so I put it on
> > kam.mff.cz/~ondra/leading_whitespace.patch
>
> That file appears not to exist.
>
Sorry, it should be kam.mff.cuni.cz/~ondra/leading_whitespace.patch
> By "fix" do you mean specifically fix cases where the <space><tab>
> sequence appears that git hooks object to, or other cases as well where
> the indentation doesn't follow the preferred rule of a maximal sequence of
> tabs followed by 0-7 spaces? I think the two should be separated,
> starting with the cases involving <space><tab>.
>
Now tabs followed by spaces. I could add detection of first.
Rest tomorrow.
Ondra