This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix leading whitespace.
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: <libc-alpha at sourceware dot org>
- Date: Wed, 5 Jun 2013 21:33:23 +0000
- Subject: Re: [PATCH] Fix leading whitespace.
- References: <20130605230815 dot GA6738 at domone dot kolej dot mff dot cuni dot cz>
On Thu, 6 Jun 2013, wizard wrote:
> It also found that posix/transbug.c is executable
> mode change 100755 => 100644 posix/transbug.c
A mode change should be a separate commit (I consider that fix obvious).
> It is 675kb file so I put it on
> kam.mff.cz/~ondra/leading_whitespace.patch
That file appears not to exist.
By "fix" do you mean specifically fix cases where the <space><tab>
sequence appears that git hooks object to, or other cases as well where
the indentation doesn't follow the preferred rule of a maximal sequence of
tabs followed by 0-7 spaces? I think the two should be separated,
starting with the cases involving <space><tab>.
> * intl/plural.c: Likewise.
No, this is a generated file; we mustn't make manual changes to it
(although it would be good to change the makefile rule to generate it to
remove the trailing whitespace the git hooks object to, to avoid that
being a manual step when the file is regenerated for checkin).
> * libidn/gunicomp.h: Likewise.
> * libidn/gunidecomp.h: Likewise.
> * libidn/nfkc.c: Likewise.
> * libidn/punycode.h: Likewise.
> * libidn/rfc3454.c: Likewise.
libidn has its own ChangeLog.
> * manual/examples/argp-ex3.c: Likewise.
> * manual/examples/fmtmsgexpl.c: Likewise.
> * manual/examples/rprintf.c: Likewise.
> * manual/examples/subopt.c: Likewise.
> * manual/examples/swapcontext.c: Likewise.
> * manual/examples/testopt.c: Likewise.
Before changing any whitespace in the manual, make sure that the output
looks correct in all of info, HTML and PDF formats. I'm not sure tabs for
indentation are necessarily handled correctly in Texinfo.
> * nptl/descr.h: Likewise.
nptl has its own ChangeLog.
> * nptl_db/td_ta_map_lwp2thr.c: Likewise.
So does nptl_db.
--
Joseph S. Myers
joseph@codesourcery.com