This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Move bench target into benchtests
- From: Siddhesh Poyarekar <siddhesh at redhat dot com>
- To: "Carlos O'Donell" <carlos at redhat dot com>
- Cc: Roland McGrath <roland at hack dot frob dot com>, libc-alpha at sourceware dot org, Tulio Magno Quites Machado Filho <tuliom at linux dot vnet dot ibm dot com>
- Date: Wed, 10 Apr 2013 10:31:37 +0530
- Subject: Re: [PATCH] Move bench target into benchtests
- References: <20130403080526 dot GA20842 at spoyarek dot pnq dot redhat dot com> <20130408220956 dot 124492C09F at topped-with-meat dot com> <20130409044525 dot GD15689 at spoyarek dot pnq dot redhat dot com> <516419D3 dot 1070007 at redhat dot com> <20130409134404 dot GM15689 at spoyarek dot pnq dot redhat dot com> <5164996A dot 1020809 at redhat dot com>
On Tue, Apr 09, 2013 at 06:42:50PM -0400, Carlos O'Donell wrote:
> On 04/09/2013 09:44 AM, Siddhesh Poyarekar wrote:
> > On Tue, Apr 09, 2013 at 09:38:27AM -0400, Carlos O'Donell wrote:
> >>> +bench: $(binaries-bench)
> >>> + for run in $^; do \
> >>> + echo "Running $${run}"; \
> >>> + eval $(run-bench) >> $(objpfx)bench.out-tmp; \
> >>
> >> Do you need `eval' here? Schwab caught this in my implementation also,
> >> and I didn't need it because all the variables were resolved by the time
> >> the command is evaluated.
> >>
> >
> > Tulio had added it IIRC to get it to work on powerpc. I'll check if
> > it is in fact needed and if not, I'll just remove it.
>
> Did he use a cross-test wrapper?
>
I don't know. Tulio, could you please clarify why you had needed the
additional 'eval' above?
Siddhesh