This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Pushing a git note fails.
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: GNU C Library <libc-alpha at sourceware dot org>, Jim Meyering <jim at meyering dot net>
- Cc: Mike Frysinger <vapier at gentoo dot org>
- Date: Sat, 06 Apr 2013 12:27:33 -0400
- Subject: Pushing a git note fails.
Team,
I did a commit, but forgot to update the ChangeLog.
Given that we've been recently talking about
ChangeLog's being icky and git notes being a cool
feature I decided to try play with adding a git note.
You can see the note here:
~~~
commit 24116fcdbe55d58aa35fc77444ae71a9dec9fff6
Author: Carlos O'Donell <carlos@redhat.com>
Date: Sat Apr 6 10:53:54 2013 -0400
s390/s390x: Undef PSEUDO before redef.
The s390 and s390x sysdep.h files include the more generic sysdep.h.
The more generic sysdep.h defines PSEUDO. This causes an annoying
CPP warning saying the PSEUDO was redefined. This patch removes the
warning by undefining PSEUDO before the redefinition. This is in line
with what all the other machines do.
---
2013-04-06 Carlos O'Donell <carlos@redhat.com>
* sysdeps/s390/s390-32/sysdep.h: Undefine PSEUDO before redefinition.
* sysdeps/s390/s390-64/sysdep.h: Likewise.
Notes:
Added ChangeLog with this commit:
b7a329a5614d9001abcc3300a3da548a0865a3ac
~~~
This note is a local "commit" namespace note and I need to
push it up to the server like this:
~~~
[carlos@koi glibc]$ git push origin refs/notes/*
Counting objects: 3, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 331 bytes, done.
Total 3 (delta 0), reused 0 (delta 0)
remote: *** Update hook: unknown type of update to ref refs/notes/commits of type commit
remote: error: hook declined to update refs/notes/commits
To ssh://carlos@sourceware.org/git/glibc.git
! [remote rejected] refs/notes/commits -> refs/notes/commits (hook declined)
error: failed to push some refs to 'ssh://carlos@sourceware.org/git/glibc.git'
~~~
But it fails.
It looks like our commit hooks don't allow notes.
Jim,
I assume you're busy. Is there any way I can be
the change that I want to see? Can I get setup
to fix this kind of thing for the community?
I'm just as happy to have you fix it though :-)
Cheers,
Carlos.
Notes:
- Great information on git notes limitations:
http://git-scm.com/2010/08/25/notes.html
- Added an extra fetch to my 'origin' to support
pulling down notes with git pull --rebase e.g.
fetch = +refs/notes/*:refs/notes/*
- Don't even think about collaborating in a note.