This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Properly collect individual tests' results (was: GNU C Library master sources branch, master, updated. glibc-2.10-282-g003c989)


Hi!

On 23 Aug 2009 18:58:16 -0000, drepper@sourceware.org wrote:
> http://sources.redhat.com/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=003c9895a89e71767ad64bafac1ca99622be2eb7
> 
> commit 003c9895a89e71767ad64bafac1ca99622be2eb7
> Author: Ulrich Drepper <drepper@redhat.com>
> Date:   Sun Aug 23 11:57:52 2009 -0700
> 
>     Print sign of NaN values.

> +	* stdio-common/tstdiomisc.c: Add more tests.

> --- a/stdio-common/tstdiomisc.c
> +++ b/stdio-common/tstdiomisc.c

> +  snprintf (buf, sizeof buf, "%a %A %e %E %f %F %g %G",
> +	    nanval, nanval, nanval, nanval, nanval, nanval, nanval, nanval);
> +  result = strcmp (buf, "nan NAN nan NAN nan NAN nan NAN") != 0;
> +  [...]
> +  result = strcmp (buf, "-nan -NAN -nan -NAN -nan -NAN -nan -NAN") != 0;
> +  [...]

Pushed as commit a8b792d6bb54fda2ff66f8b0c725397d402f367e:

	* stdio-common/tstdiomisc.c (F): Properly collect individual
	tests' results.

diff --git stdio-common/tstdiomisc.c stdio-common/tstdiomisc.c
index d24c55f..fa07aa5 100644
--- stdio-common/tstdiomisc.c
+++ stdio-common/tstdiomisc.c
@@ -57,20 +57,20 @@ F (void)
 {
   char buf[80];
   wchar_t wbuf[40];
-  int result;
+  int result = 0;
 
   qnanval = NAN;
 
   snprintf (buf, sizeof buf, "%a %A %e %E %f %F %g %G",
 	    qnanval, qnanval, qnanval, qnanval,
 	    qnanval, qnanval, qnanval, qnanval);
-  result = strcmp (buf, "nan NAN nan NAN nan NAN nan NAN") != 0;
+  result |= strcmp (buf, "nan NAN nan NAN nan NAN nan NAN") != 0;
   printf ("expected \"nan NAN nan NAN nan NAN nan NAN\", got \"%s\"\n", buf);
 
   snprintf (buf, sizeof buf, "%a %A %e %E %f %F %g %G",
 	    -qnanval, -qnanval, -qnanval, -qnanval,
 	    -qnanval, -qnanval, -qnanval, -qnanval);
-  result = strcmp (buf, "-nan -NAN -nan -NAN -nan -NAN -nan -NAN") != 0;
+  result |= strcmp (buf, "-nan -NAN -nan -NAN -nan -NAN -nan -NAN") != 0;
   printf ("expected \"-nan -NAN -nan -NAN -nan -NAN -nan -NAN\", got \"%s\"\n",
 	  buf);
 
@@ -118,13 +118,13 @@ F (void)
   snprintf (buf, sizeof buf, "%La %LA %Le %LE %Lf %LF %Lg %LG",
 	    lqnanval, lqnanval, lqnanval, lqnanval,
 	    lqnanval, lqnanval, lqnanval, lqnanval);
-  result = strcmp (buf, "nan NAN nan NAN nan NAN nan NAN") != 0;
+  result |= strcmp (buf, "nan NAN nan NAN nan NAN nan NAN") != 0;
   printf ("expected \"nan NAN nan NAN nan NAN nan NAN\", got \"%s\"\n", buf);
 
   snprintf (buf, sizeof buf, "%La %LA %Le %LE %Lf %LF %Lg %LG",
 	    -lqnanval, -lqnanval, -lqnanval, -lqnanval,
 	    -lqnanval, -lqnanval, -lqnanval, -lqnanval);
-  result = strcmp (buf, "-nan -NAN -nan -NAN -nan -NAN -nan -NAN") != 0;
+  result |= strcmp (buf, "-nan -NAN -nan -NAN -nan -NAN -nan -NAN") != 0;
   printf ("expected \"-nan -NAN -nan -NAN -nan -NAN -nan -NAN\", got \"%s\"\n",
 	  buf);
 


GrÃÃe,
 Thomas

Attachment: pgpQIGAKhT4dp.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]