This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] fi_FI: Define yesstr, nostr
- From: Marko Myllynen <myllynen at redhat dot com>
- To: "Carlos O'Donell" <carlos at redhat dot com>
- Cc: Keld Simonsen <keld at keldix dot com>, libc-alpha at sourceware dot org
- Date: Wed, 20 Mar 2013 17:50:02 +0200
- Subject: Re: [PATCH] fi_FI: Define yesstr, nostr
- References: <5141EF6D dot 9000601 at redhat dot com> <514334DF dot 8000306 at redhat dot com> <51434336 dot 3020103 at redhat dot com>
- Reply-to: myllynen at redhat dot com
Hi,
On 2013-03-15 17:50, Carlos O'Donell wrote:
> On 03/15/2013 10:49 AM, Carlos O'Donell wrote:
>> On 03/14/2013 11:40 AM, Marko Myllynen wrote:
>>>
>>> attached is a patch to define yesstr/nostr in fi_FI (as "KyllÃ" and
>>> "Ei", obviously). I happened to notice BZ #15264 so this is related
>>> but definitely does not warrant closing it so I chose to omit the
>>> reference from the ChangeLog entry.
>>>
>>> localedata/
>>>
>>> 2013-03-14 Marko Myllynen <myllynen@redhat.com>
>>>
>>> * locales/fi_FI (LC_MESSAGES): Define yesstr, nostr.
>>
>> This looks good to me, could you do me a favour?
>>
>> (a) Include in a comment the unicode values of yesstr/nostr, this makes
>> review easier for future readers.
I'm not sure is this really needed, see below.
>> (b) Can you build the library to make sure the locale is compiled correctly
>> and without error?
I think the most efficient way to test such an isolated locale change is
to do something like the following (which is what I've used now and in
the past):
localhost:~> unset LANG LC_ALL LC_COLLATE LC_CTYPE LC_MESSAGES LC_TIME
localhost:~> LOCALE=fi_FI
localhost:~> export I18NPATH=$HOME/locale-test/
localhost:~> export LOCPATH=$HOME/locale-test/
localhost:~> mkdir -p $LOCPATH
localhost:~> localedef -f UTF-8 -i ./$LOCALE $I18NPATH/$LOCALE.UTF-8
localhost:~> LANG=$LOCALE.UTF-8 locale -ck LC_MESSAGES
LC_MESSAGES
yesexpr="^[KkYy].*"
noexpr="^[EeNn].*"
yesstr="KyllÃ"
nostr="Ei"
messages-codeset="UTF-8"
localhost:~>
This also makes it as easy as an comment to review these particular values.
>> I've included Keld in the TO since as the author of the locale it would
>> be nice if he could comment on the change.
>>
>> After review, and once we checkin your changes you should update the BZ
>> to indicate you've fixed fi_FI.
Review is good but were you aware that you are asking a non-native
speaker to review the translation of Yes/No by a native speaker?-) More
seriously, the translations I've provided are also present in the CLDR
data for fi.
Cheers,
--
Marko Myllynen