This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Ping: [PATCH v4] faster strlen on x64
On Fri, Mar 15, 2013 at 10:29:49AM -0400, Carlos O'Donell wrote:
> On 03/15/2013 07:49 AM, OndÅej BÃlka wrote:
> > On Tue, Mar 12, 2013 at 09:24:07AM -0400, Carlos O'Donell wrote:
> >> On 03/11/2013 05:15 AM, OndÅej BÃlka wrote:
> >>> Carlos, what is you opinion?
> >>
> >> The patch looks good. I have one last question though.
> >>
> >> We remove some interesting code in the existing strlen implementations
> >> that ensure that strlen calls from libc itself do not go through the PLT.
> >>
> >> Have you verified that after your changes there are no testsuite regressions
> >> in the plt check test or that the internal calls to strlen avoid the PLT?
> >>
> >> OK to checkin after this additional validation with posted result.
> >>
> >
> > I ran http://sourceware.org/glibc/wiki/Testing/Check-localplt
> > elf/checklocalplt.out is empty. I guess this means no regressions.
>
> Correct.
>
> Cheers,
> Carlos.
Commited with obvious resolution of merge conflict in
sysdeps/x86-64/multiarch/Makefile.