This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch] Cleanup: set LC_ALL=C before invoking sed on non-ASCII data
- From: Siddhesh Poyarekar <siddhesh dot poyarekar at gmail dot com>
- To: Paul Pluzhnikov <ppluzhnikov at google dot com>
- Cc: libc-alpha at sourceware dot org, ronis at google dot com
- Date: Sat, 9 Mar 2013 09:38:57 +0530
- Subject: Re: [patch] Cleanup: set LC_ALL=C before invoking sed on non-ASCII data
- References: <ye6qwqthuy93.fsf@elbrus2.mtv.corp.google.com>
On 9 March 2013 07:32, Paul Pluzhnikov <ppluzhnikov@google.com> wrote:
> Greetings,
>
> On Ubuntu Precise, with LANG=en_US.UTF-8, this sed in posix/
>
> sed -f PTESTS2C.sed < PTESTS > ptestcases.h
>
> produces a "corrupt" file ptestcases.h file (line 233), causing subsequent
> "make check" to fail.
>
>
> --
>
> 2013-03-08 Paul Pluzhnikov <ppluzhnikov@google.com>
>
> * posix/Makefile: Set LC_ALL=C before sed.
This should be:
* posix/Makefile (testcases.h): Set LC_ALL=C before sed.
(ptestcases.h): Likewise.
The fix is fine.
Thanks,
Siddhesh
--
http://siddhesh.in