This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Cleanup: don't call free(NULL) unnecessarily


On Wed, Mar 6, 2013 at 12:27 AM, Thomas Schwinge
<thomas@codesourcery.com> wrote:

> Given that in the past, for example, in commits
> 62605cbfcb3d2f118c9f64ce049220b82928e6d4 ...
> such checks have been removed,

Thanks for pointing this out.

> does this (and likewise for other cases) warrant a comment being added,
> or some other form of (user-accessible) documentation update what this
> change achieves?

Sounds good to me, but I am not sure how to achieve this.

Adding a comment to every "if (__glibc_unlikely(...))" seems
excessive; adding it to only some of the if's makes it likely that the
other if's will get killed again :-(

Thanks,
-- 
Paul Pluzhnikov


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]