This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix build warnings in regex.c, bug-regex20.c, bug-regex33.c
> On Thu, Feb 21, 2013 at 11:10:05AM -0800, Roland McGrath wrote:
> > Please be consistent in using __attribute__ (with trailing underscores).
> > Otherwise fine.
>
> OK, I'll fix it in elem-hash.h. __attribute is conditionally defined
> in regex_internal.h to make it work with non-gnu compilers. It's not
> an installed header, so if it's OK, I'll just remove that conditional
> definition and use __attribute__ there as well.
That seems right.