This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Use long wherever possible in mpa.c
- From: Andreas Jaeger <aj at suse dot com>
- To: libc-alpha at sourceware dot org
- Date: Thu, 21 Feb 2013 10:32:09 +0100
- Subject: Re: [PATCH] Use long wherever possible in mpa.c
- References: <20130221092336.GA7508@spoyarek.pnq.redhat.com>
On 02/21/2013 10:23 AM, Siddhesh Poyarekar wrote:
Hi,
Here's another patch to sync up code between powrpc and generic mpa.c,
this time the change being in the generic code. Using long throughout
like powerpc does is beneficial since it reduces the need to switch to
32-bit instructions. It gives a very minor performance improvement
(~0.4%). OK to commit?
Have you done any measurements on 32-bit architectures? What's the result?
The patch itself is fine and if there's performance degreation on 32-bit
architectures, go ahead.
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126