This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [COMMITTED PATCH] Remove a lot of inline keywords


> > In general, I think we should eschew the inline keyword entirely when used
> > alone.  If it really matters that something be inlined, it needs
> > always_inline.  Otherwise we should leave optimization decisions to the
> > compiler unless there is a particular strong reason in an individual case.
> > Any such cases should have clear comments saying why the explicit inline
> > is desireable.
> 
> Agreed.

That said, it would be worthwhile for one of our volunteer
microoptimization junkies to do builds before and after my
change and analyze the code differences looking for places
where inlining seems preferable.


Thanks,
Roland


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]