This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] malloca v2
On Sat, Jan 12, 2013 at 09:36:16PM +0100, Andreas Schwab wrote:
> OndÅej BÃlka <neleai@seznam.cz> writes:
>
> > + #define __MALLOCA_EBP __builtin_frame_address(0)
>
> __MALLOCA_EBP is a terrible name.
I am not sure what is better name. Does __MALLOCA_FRAME_ADDRESS sound better?
>
> > + char *short_no_arg_opts = NULL;
> > if (hol->num_entries > 0)
> > {
> > unsigned nentries;
> > struct hol_entry *entry;
> > - char *short_no_arg_opts = alloca (strlen (hol->short_options) + 1);
> > + short_no_arg_opts = malloca (strlen (hol->short_options) + 1);
> > char *snao_end = short_no_arg_opts;
> >
> > /* First we put a list of short options without arguments. */
>
> What's that for?
This was example of usage from previous patch. There it was used for
freeing, which is no useless.
Also I choosed this file as example only because it was alphabeticaly first.
>
> Andreas.
>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
> "And now for something completely different."
--
because of network lag due to too many people playing deathmatch