This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][s390] Replace lll_futex_* assembly code with INTERNAL_SYSCALL


On 12/20/2012 05:28 AM, Siddhesh Poyarekar wrote:
>> The patch below replaces the assembly implementation of the
>> lll_futex_* macros in s390 lowlevellock.h with calls to the
>> INTERNAL_SYSCALL macro.  The aim is to reduce assembly language usage
>> where possible so that in future we have the opportunity (and I think
>> we do, based on my reading of the lowlevellock.h implementations in
>> various archs) to consolidate this code across architectures whenever
>> possible.
>> 
>> I've verified that this does not cause any regressions on s390x.
>> 
>> OK to commit once the freeze is lifted?

Looks good to me.  Waiting until after the freeze will certainly give
the s390 maintainers time to raise any concerns they might have, but
it's certainly straight-forward.


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]