This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: Use __get_cpu_features () in HAS_CPUID_FLAG
- From: Richard Henderson <rth at twiddle dot net>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: "H.J. Lu" <hongjiu dot lu at intel dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 13 Dec 2012 08:42:13 -0800
- Subject: Re: PATCH: Use __get_cpu_features () in HAS_CPUID_FLAG
- References: <20121212225922.GA26326@intel.com>
On 12/12/2012 02:59 PM, H.J. Lu wrote:
> are called only within __init_cpu_features, where we can't
> call __get_cpu_features without infinite recursion. */
> # define HAS_CPUID_FLAG(idx, reg, bit) \
> - (((&__cpu_features)->cpuid[idx].reg & (bit)) != 0)
> + ((__get_cpu_features ()->cpuid[idx].reg & (bit)) != 0)
Read the comment above, the important bit of which can even be read
within this context.
r~