Re: [PATCH] Add ldconfig cache tag handling for ARM hard-float ABI

["Carlos O'Donell" <carlos at systemhalted dot org>]

On Thu, Nov 15, 2012 at 8:26 PM, Steve McIntyre
<steve.mcintyre@linaro.org> wrote:
[snip]
> Patch v2 here:
>
> =====================================================================
> Add ldconfig cache tag handling for ARM hard-float ABI
>
>         * sysdeps/generic/ldconfig.h (FLAG_ARM_LIBHF): New macro.
>         * elf/cache.c (print_entry): Print ",hard-float" for
>         FLAG_ARM_LIBHF.
>
> Signed-off-by: Steve McIntyre <steve.mcintyre@linaro.org>
> ---
>  ChangeLog                  |    6 ++++++
>  elf/cache.c                |    5 ++++-
>  sysdeps/generic/ldconfig.h |    1 +
>  3 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/ChangeLog b/ChangeLog
> index f5a3645..885587c 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,9 @@
> +2012-11-15  Steve McIntyre  <steve.mcintyre@linaro.org>
> +
> +       * sysdeps/generic/ldconfig.h (FLAG_ARM_LIBHF): New macro.
> +       * elf/cache.c (print_entry): Print ",hard-float" for
> +       FLAG_ARM_LIBHF.
> +
>  2012-11-14  Marcus Shawcroft  <marcus.shawcroft@linaro.org>
>
>         * io/Makefile (CFLAGS-open.c, CFLAGS-open64.c): Define.
> diff --git a/elf/cache.c b/elf/cache.c
> index db8b9fa..08ccd2e 100644
> --- a/elf/cache.c
> +++ b/elf/cache.c
> @@ -1,4 +1,4 @@
> -/* Copyright (C) 1999-2003,2005,2006,2007,2011 Free Software Foundation, Inc.
> +/* Copyright (C) 1999-2003,2005-2007,2011,2012 Free Software Foundation, Inc.

Read the rules closely, this should be "1999-2012"

http://sourceware.org/glibc/wiki/Contribution%20checklist

>     This file is part of the GNU C Library.
>     Contributed by Andreas Jaeger <aj@suse.de>, 1999.
>
> @@ -94,6 +94,9 @@ print_entry (const char *lib, int flag, unsigned int osversion,
>      case FLAG_X8664_LIBX32:
>        fputs (",x32", stdout);
>        break;
> +    case FLAG_ARM_LIBHF:
> +      fputs (",hard-float", stdout);
> +      break;
>      case 0:
>        break;
>      default:
> diff --git a/sysdeps/generic/ldconfig.h b/sysdeps/generic/ldconfig.h
> index ef3f4b9..1c8cc9d 100644
> --- a/sysdeps/generic/ldconfig.h
> +++ b/sysdeps/generic/ldconfig.h

Should be merged to "1999-2012"

> @@ -34,6 +34,7 @@
>  #define FLAG_MIPS64_LIBN32     0x0600
>  #define FLAG_MIPS64_LIBN64     0x0700
>  #define FLAG_X8664_LIBX32      0x0800
> +#define FLAG_ARM_LIBHF         0x0900
>
>  /* Name of auxiliary cache.  */
>  #define _PATH_LDCONFIG_AUX_CACHE "/var/cache/ldconfig/aux-cache"
> --
> 1.7.10.4

Repost with those changes.

Do you need me to commit this for you?

Cheers,
Carlos.