This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PING] [PING] [PATCH][BZ #13950] add commenting notation (%)to FIXME entries to locales for bo_CN and bo_IN


On 11/14/2012 07:47 PM, Carlos O'Donell wrote:
On Wed, Nov 14, 2012 at 11:13 AM, Andreas Jaeger <aj@suse.com> wrote:
On 11/11/2012 01:15 PM, Chris Leonard wrote:

Second ping for action


The values you change are required values,and thus we get now warnings like:

if you run "make localedata/install-locales", you'll get:
bo_CN.UTF-8...LC_NAME: field `name_fmt' not defined
LC_ADDRESS: field `postal_fmt' not defined
  done
bo_IN.UTF-8...LC_NAME: field `name_fmt' not defined
LC_ADDRESS: field `postal_fmt' not defined
  done

So, what's better - no value or an obviously wrong value?

No value is better.


This is the name format and it's not obvious to a non-native english
speaker what FIXME is.

I would say the following list is in decreasing order of correctness:

(1) The correct value.
(2) No value.
(3) "" (blank)
(4) Garbage e.g. "FIXME"

In that case, I'll commit Chris' patch tomorrow unless somebody objects...


Andreas
--
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]