This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Support cross-testing (version 3)
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Andreas Schwab <schwab at linux-m68k dot org>
- Cc: Roland McGrath <roland at hack dot frob dot com>, <libc-alpha at sourceware dot org>
- Date: Fri, 2 Nov 2012 17:43:51 +0000
- Subject: Re: Support cross-testing (version 3)
- References: <Pine.LNX.4.64.1210242035130.14661@digraph.polyomino.org.uk><20121024213718.0A4FC2C09B@topped-with-meat.com><Pine.LNX.4.64.1210242300040.14661@digraph.polyomino.org.uk> <m2a9uz9ac1.fsf@igel.home>
On Fri, 2 Nov 2012, Andreas Schwab wrote:
> > +# Unset all variables from the blacklist. Then echo all exported
> > +# variables. The 'export -p' command adds backslashes for environment
> > +# variables which contain newlines.
> > +blacklist_exports ()
> > +{
> > + (unset ${env_blacklist}; export -p) | remove_newlines
>
> If called by bash, export -p outputs series of declare -x commands,
> which will fail if the remote /bin/sh is not bash.
"declare -x" was meant to be replaced by "export" in the post-processing
of "export -p" output, but it seems that got lost when revising the
script. (That post-processing isn't, I think, actually safe in general
for environment variables whose values contain newlines; it was meant to
be an optimization, but I'd be happy for it to be removed and for
environment settings with newlines between successive "export" commands
just to be passed as-is to the remote system.)
> (bourne_quote): Remove use of local.
bourne_quote is still bash-specific unless you redo the
${arg//\'/\'\\\'\'} used for quoting.
--
Joseph S. Myers
joseph@codesourcery.com