This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH siddhesh/wait_bitset] Use FUTEX_WAIT_BITSET forpthread_cond_timedwait for non-x86: ppc, s390
- From: Siddhesh Poyarekar <siddhesh at redhat dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: Roland McGrath <roland at hack dot frob dot com>, libc-alpha at sourceware dot org, rsa at us dot ibm dot com, Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>
- Date: Thu, 1 Nov 2012 08:03:44 +0530
- Subject: Re: [PATCH siddhesh/wait_bitset] Use FUTEX_WAIT_BITSET forpthread_cond_timedwait for non-x86: ppc, s390
- References: <20121022182330.4f774b71@spoyarek><20121024000039.5492B2C061@topped-with-meat.com><20121026154911.11670185@spoyarek>
Ryan, Andreas,
Did you guys get a chance to look at the ppc and s390 changes in this:
http://sourceware.org/ml/libc-alpha/2012-10/msg00571.html
with a minor (non arch-specific) fix here:
http://sourceware.org/ml/libc-alpha/2012-10/msg00758.html
It's all there in the siddhesh/wait_bitset branch.
Thanks,
Siddhesh
On Fri, 26 Oct 2012 15:49:11 +0530, Siddhesh wrote:
> Hi,
>
> Sorry, there was a bug in my patch in the clockbit condition that I
> had fixed during testing but forgot to bring back into the patch
> during submission. Here's an updated patch in which everything else
> is the same except for the flipped condition for clockbit. Verified
> once again on powerpc and s390.
>
> Also coming up shortly is another patch with a similar change for
> pthread_rwlock_timed*lock and __lll_robust_timedlock_wait.
>
> Regards,
> Siddhesh
>
> nptl/ChangeLog:
>
> * pthread_cond_timedwait.c (__pthread_cond_timedwait): Time
> out if absolute timeout is negative.
> [__ASSUME_FUTEX_CLOCK_REALTIME &&
> lll_futex_timed_wait_bitset]: Use lll_futex_timed_wait_bitset.
> * sysdeps/unix/sysv/linux/powerpc/lowlevellock.h
> (lll_futex_timed_wait_bitset): New macro.
> * sysdeps/unix/sysv/linux/s390/lowlevellock.h
> (lll_futex_timed_wait_bitset): Likewise.