This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Support cross-testing (version 3)


On Thu, 25 Oct 2012, Roland McGrath wrote:

> mentioning this script.  But (unless I missed it go by, in which case I
> apologize) we could still use an addition there talking about the
> test-wrapper and test-wrapper-env variables in general.

How does this see for general documentation?  Tested with "make info html 
pdf".

"all environment variables set as part of testing" isn't very helpful, but 
there isn't any clear definition of what environment variables must be 
preserved (to indicate that what cross-test-ssh.sh does with its 
particular blacklist is OK).  Ideally I think we wouldn't have this 
environment preservation requirement at all - all environment variables 
relevant to testing would be passed using test-wrapper-env.  But right now 
there are various places where environment variables are set in ad hoc 
test commands in makefiles, or in ad hoc shell scripts (including at the 
top of those scripts), and it's expected that they are in effect when test 
programs are run - the cases where those variables prevent wrappers from 
working (e.g. those affecting the dynamic linker) are using 
test-wrapper-env, but not all the other ad hoc cases.

2012-10-25  Joseph Myers  <joseph@codesourcery.com>

	* manual/install.texi (Configuring and compiling): Document
	general use of test-wrapper and test-wrapper-env.
	* INSTALL: Regenerated.

diff --git a/INSTALL b/INSTALL
index 9c62786..03d6eb7 100644
--- a/INSTALL
+++ b/INSTALL
@@ -204,6 +204,17 @@ HOSTNAME is the host name of a system that can run the newly built
 binaries of the GNU C Library.  The source and build directories must
 be visible at the same locations on both the build system and HOSTNAME.
 
+   In general, `test-wrapper' may be set when testing the GNU C Library
+to the name and arguments of any program to run newly built binaries.
+This program must preserve the arguments to the binary being run, its
+working directory, all environment variables set as part of testing and
+the standard input, output and error file descriptors.  If
+`TEST-WRAPPER env' will not work to run a program with environment
+variables set, then `test-wrapper-env' must be set to a program that
+runs a newly built program with environment variable assignments in
+effect, those assignments being specified as `VAR=VALUE' before the
+name of the program to be run.
+
 Installing the C Library
 ========================
 
diff --git a/manual/install.texi b/manual/install.texi
index c82b918..850e696 100644
--- a/manual/install.texi
+++ b/manual/install.texi
@@ -233,6 +233,17 @@ the newly built binaries of @theglibc{}.  The source and build
 directories must be visible at the same locations on both the build
 system and @var{hostname}.
 
+In general, @samp{test-wrapper} may be set when testing @theglibc{} to
+the name and arguments of any program to run newly built binaries.
+This program must preserve the arguments to the binary being run, its
+working directory, all environment variables set as part of testing
+and the standard input, output and error file descriptors.  If
+@samp{@var{test-wrapper} env} will not work to run a program with
+environment variables set, then @samp{test-wrapper-env} must be set to
+a program that runs a newly built program with environment variable
+assignments in effect, those assignments being specified as
+@samp{@var{var}=@var{value}} before the name of the program to be run.
+
 
 @node Running make install
 @appendixsec Installing the C Library

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]