This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PING: PATCH: Automatically test IFUNC implementations
> * Rules [$(multi-arch) = no] (tests): Filter out $(tests-ifunc).
> [$(multi-arch) = no] (xtests): Filter out $(xtests-ifunc).
> * include/ifunc-impl-list.h: New file.
> * misc/ifunc-impl-list.c: Likewise.
> * misc/Makefile (routines): Add ifunc-impl-list.
> * misc/Versions (GLIBC_PRIVATE): __libc_ifunc_impl_list.
"Add ..."
> (FOR_EACH_IMPL): Support func_list if TEST_IFUNC and TEST_NAME
> are defined.
> (test_init): Call __libc_ifunc_impl_list to initialize
> func_list if TEST_IFUNC and TEST_NAME are defined.
[TEST_IFUNC && TEST_NAME] (FOR_EACH_IMPL): Define to use func_list.
(test_init) [TEST_IFUNC && TEST_NAME]: Initialize func_list.
> +#if defined TEST_IFUNC && defined TEST_NAME
> +# define SIZEOF_ARRAY(array) (sizeof array / sizeof array[0])
This macro is not used. Remove it.
The rest is OK by me with those changes.
Thanks,
Roland