This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Improve x86-64 bcopy/bzero


> --- /dev/null
> +++ b/string/test-bcopy.c
> @@ -0,0 +1,262 @@
> +/* Test and measure bcopy functions.

Please modify test-memmove.c with some macro use so this can
just #define some things and #include it instead of duplicating it.
Likewise for test-bzero.c vs test-memset.c.

>  ENTRY(bcopy)
>  	xchg	%rdi, %rsi
> -	jmp	HIDDEN_BUILTIN_JUMPTARGET(memmove)
> +	jmp	__libc_memmove

Add a comment saying we are intentionally using the PLT entry here.

> +	jmp	__libc_memset
> +END(__bzero)

Likewise.

> --- a/sysdeps/x86_64/multiarch/memset.S
> +++ b/sysdeps/x86_64/multiarch/memset.S
> @@ -1,5 +1,5 @@
>  /* Multiple versions of memset
> -   Copyright (C) 2010 Free Software Foundation, Inc.
> +   Copyright (C) 2010-12 Free Software Foundation, Inc.

No two-digit years.


Thanks,
Roland


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]