This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] BZ #14545: Always check dtv before freeing dtv[-1]


On Thu, Sep 6, 2012 at 7:11 AM, Andreas Jaeger <aj@suse.com> wrote:
> On Thursday, September 06, 2012 06:02:00 H.J. Lu wrote:
>> On Thu, Sep 6, 2012 at 5:49 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> > On Thu, Sep 6, 2012 at 1:08 AM, Andreas Jaeger <aj@suse.com> wrote:
>> >> On Wednesday, September 05, 2012 13:21:07 H.J. Lu wrote:
>> >>> Hi,
>> >>>
>> >>> We should always check dtv before freeing dtv[-1], including in
>> >>> libc.a, since dtv is a static array in libc.a.  _dl_initial_dtv
>> >>> is intialized to &static_dtv[1] so that index -1 contains the
>> >>> length.
>> >>> Testd on Linux/x86-64.  OK to install?
>> >>
>> >> Could you add a test for the testsuite, please?
>> >
>> > Many tests failed statically to due
>> >
>> > http://sourceware.org/bugzilla/show_bug.cgi?id=14544
>> >
>> > A patch was posted at
>> >
>> > http://sourceware.org/ml/libc-alpha/2012-09/msg00059.html
>> >
>> > I need to apply this before adding a test.
>>
>> Here is the testcase.  But it fails even with my fix for PR 14545
>> due to PR 14544.
>
> Please submit the test case once both bugs are fixed.
>

Now, PR 14544 is fixed. Here are patches for PR 14545 with
a new case  Tested on x86-64.  OK to install?

Thanks.

-- 
H.J.

Attachment: 0001-Add-tst-cancel21-static.c.patch
Description: Binary data

Attachment: 0002-Always-check-dtv-before-freeing-dtv-1.patch
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]