This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: [BZ #14476]: test-installation.pl fails on x86_64
On 8/29/2012 11:35 AM, H.J. Lu wrote:
> On Wed, Aug 29, 2012 at 8:15 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Wed, Aug 29, 2012 at 8:11 AM, Carlos O'Donell
>> <carlos_odonell@mentor.com> wrote:
>>> On 8/29/2012 7:06 AM, Andreas Jaeger wrote:
>>>> On Tuesday, August 28, 2012 12:39:36 H.J. Lu wrote:
>>>>> Hi,
>>>>>
>>>>> scripts/test-installation.pl reads soversions.mk. But it doesn't
>>>>> understand
>>>>>
>>>>> ld.so-version=$(if $(abi-64-ld-soname),$(abi-64-ld-soname),ld.so.1)
>>>>>
>>>>> This patch passes LD_SO=$(ld.so-version) to
>>>>> scripts/test-installation.pl and uses it to set $ld_so_name and
>>>>> $ld_so_version. OK to install?
>>>>
>>>> Thanks, this looks fine.
>>>>
>>>> Carlos, I suggest this fix also as a backport for 2.16,
>>>
>>> I'm OK with that.
>>>
>>> H.J. could you please test and check this into the 2.16 branch?
>>>
>>
>> I will run some manual test. But my "make install" won't use
>> it since I pass install_root= to "make install".
>>
>>
>
> I checked it into release/2.16/master branch.
>
Thanks!
Cheers,
Carlos.
--
Carlos O'Donell
Mentor Graphics / CodeSourcery
carlos_odonell@mentor.com
carlos@codesourcery.com
+1 (613) 963 1026