This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix up bswap_* types
On Wed, Aug 22, 2012 at 01:12:24PM -0700, Roland McGrath wrote:
> They are wrong to include <endian.h>, which declares public symbols.
> They should use only <bits/endian.h> instead. This means all the various
> bits/endian.h files need their #ifndef _ENDIAN_H sanity checks adjusted.
In that case I think I could in {w,}ctype.h before including
<bits/endian.h> define say `__need_byteorder' and then tweak guards
in all the bits/endian.h so that they look like
#if !defined _ENDIAN_H && !defined __need_byteorder
# error blah...
#endif
And it also looks that I have to move following definitions:
#define __LITTLE_ENDIAN 1234
#define __BIG_ENDIAN 4321
#define __PDP_ENDIAN 3412
from string/endian.h to ctype/ctype.h, otherwise charset test
when running check just blow up.
What do ya say?
Marek