This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] add attribute_hidden to __have_{sock_cloexec,pipe2,dup3
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 17 Aug 2012 21:55:06 -0700 (PDT)
- Subject: Re: [PATCH] add attribute_hidden to __have_{sock_cloexec,pipe2,dup3
- References: <1345265246-6635-1-git-send-email-vapier@gentoo.org>
Looks good.
It's unfortunate that any of those declarations appear in more than one
include/ header file. Maybe we can just make sure that any users of
__have_sock_cloexec include <sys/socket.h>?
It would be worthwhile for someone to check include/*.h for any other
duplicate declarations.
Thanks,
Roland