This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Split tls-macros.h into sysdeps directories
On Wed, Jul 11, 2012 at 9:36 AM, Adhemerval Zanella
<azanella@linux.vnet.ibm.com> wrote:
> On 07/10/2012 08:51 PM, Joseph S. Myers wrote:
>> Tested x86_64 and x86. Could architecture maintainers test / review
>> for the other architectures? Given the presence of a common macro
>> used for both powerpc32 and powerpc64, I put both powerpc32 and
>> powerpc64 versions in a single file in sysdeps, but powerpc
>> maintainers may wish to split things up further.
>
> It is ok for powerpc32 and powerpc64, but I would suggest the following changes
> (based on your patch) to split the code in powerpc32 and powerpc64 folder and
> avoid internal #ifdefs. What do you think Ryan?
I like it split out like you've done here.
> diff --git a/sysdeps/powerpc/powerpc64/tls-macros.h b/sysdeps/powerpc/powerpc64/tls-macros.h
> new file mode 100644
> index 0000000..955fa0c
> --- /dev/null
> +++ b/sysdeps/powerpc/powerpc64/tls-macros.h
> @@ -0,0 +1,45 @@
> +#include_next "tls-macros.h"
You could add a comment before this include indicating that it's being
done to pick up the clobber list macro.
Ryan S. Arnold