This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: #ifndef SHARED in pthread.h
On Mon, Jun 4, 2012 at 2:18 PM, Carlos O'Donell <carlos@systemhalted.org> wrote:
> On Mon, Jun 4, 2012 at 1:50 PM, Roland McGrath <roland@hack.frob.com> wrote:
>>> There is a hidden definition of __pthread_unwind_next in nptl/unwind.c.
>>
>> It's a public, exported definition. ?It also has a hidden_def declaration
>> because i386's and SH's pthread_once implementation uses it internally.
>>
>>> Where would a second definition of __pthread_unwind_next come from?
>>
>> There is no other.
>
> Well, if there is no other then why mark it weak?
Sorry, I realize that sounded more aggressive than I meant it to sound.
If there is no other definition, and this is an internal function that
we wouldn't allow users to override, then the entire conditional block
should just be deleted?
Cheers,
Carlos.