This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][BZ #14188] Allow pthread_cleanup_push to build withcompilers other than gcc

From: Roland McGrath <roland at hack dot frob dot com>
To: Siddhesh Poyarekar <siddhesh at redhat dot com>
Cc: Jakub Jelinek <jakub at redhat dot com>, libc-alpha at sourceware dot org
Date: Fri, 1 Jun 2012 12:41:48 -0700 (PDT)
Subject: Re: [PATCH][BZ #14188] Allow pthread_cleanup_push to build withcompilers other than gcc
References: <20120601183039.16a24b5b@spoyarek><20120601152433.GA15191@sunsite.ms.mff.cuni.cz><20120602010159.17f74b8e@spoyarek>

This is the only use of __builtin_expect in a public header now.
But it seems reasonably likely that we'll have others eventually.
So my inclination would be to put the macro in sys/cdefs.h and give
it a different name.  (Or perhaps also slightly different semantics,
e.g. __glibc_unlikely(BOOL).)


Thanks,
Roland

Follow-Ups:
- Re: [PATCH][BZ #14188] Allow pthread_cleanup_push to build withcompilers other than gcc
  - From: Siddhesh Poyarekar

References:
- [PATCH][BZ #14188] Allow pthread_cleanup_push to build withcompilers other than gcc
  - From: Siddhesh Poyarekar
- Re: [PATCH][BZ #14188] Allow pthread_cleanup_push to build withcompilers other than gcc
  - From: Jakub Jelinek
- Re: [PATCH][BZ #14188] Allow pthread_cleanup_push to build withcompilers other than gcc
  - From: Siddhesh Poyarekar

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]