This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: RFA: Port maintainers: Convert WORDSIZE[32|64]/ld to abi-variants
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, libc-ports at sourceware dot org, Thomas Schwinge <thomas at codesourcery dot com>, Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>, Andreas Krebbel <Andreas dot Krebbel at de dot ibm dot com>, David Miller <davem at davemloft dot net>
- Date: Fri, 1 Jun 2012 07:21:01 -0700
- Subject: Re: RFA: Port maintainers: Convert WORDSIZE[32|64]/ld to abi-variants
- References: <20120526133641.GA9655@intel.com><Pine.LNX.4.64.1205261648450.16948@digraph.polyomino.org.uk><CAMe9rOouyXcgkBAkRF+XV2m2icHh3tAWOkMCLLd5LA8=qQkqMw@mail.gmail.com><Pine.LNX.4.64.1205261919230.16948@digraph.polyomino.org.uk><CAMe9rOpV=AgDvj91D06Bgr4Q_k5B1PGFDN4LK1OquVkx+b0yUw@mail.gmail.com><Pine.LNX.4.64.1205311513500.7338@digraph.polyomino.org.uk><CAMe9rOpUEDRrvh1hXQJqut_uvyitfUs7sn+72fQ5W=fdE2GP3g@mail.gmail.com><Pine.LNX.4.64.1206011404100.2129@digraph.polyomino.org.uk>
On Fri, Jun 1, 2012 at 7:06 AM, Joseph S. Myers <joseph@codesourcery.com> wrote:
> On Thu, 31 May 2012, H.J. Lu wrote:
>
>> On Thu, May 31, 2012 at 8:17 AM, Joseph S. Myers
>> <joseph@codesourcery.com> wrote:
>> > HJ, I don't see how default-abi gets set for powerpc, s390 or sparc - I
>> > think you're missing appropriate settings in six sysdeps makefiles for
>> > those.
>> >
>> > The setting in Makeconfig
>> >
>> > ifdef abi-variants
>> > ifndef default-abi
>> > default-abi = $(firstword $(abi-variants))
>> > endif
>> > endif
>>
>> This should be removed then and powerpc, s390 or sparc
>> should define default-abi. ?But I don't know them well enough
>> to add it myself.
>
> Here is the (untested) patch I propose to add the default-abi definitions
> so that these architectures again install the correct stubs-<abi>.h
> instead of "stubs-.h".
>
Can you also remove
ifdef abi-variants
ifndef default-abi
default-abi = $(firstword $(abi-variants))
endif
endif
in Makeconfig?
Thanks.
--
H.J.