This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: Update sysdeps/x86_64/start.S for x32.
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 14 May 2012 15:34:07 -0700 (PDT)
- Subject: Re: PATCH: Update sysdeps/x86_64/start.S for x32.
- References: <20120514221234.GA27440@intel.com>
> - 0(%rsp) argc
> - 8(%rsp) argv[0]
> + 0(%rsp) argc
> + LP_SIZE(%rsp) argv[0]
> ...
> - (8*argc)(%rsp) NULL
> - (8*(argc+1))(%rsp) envp[0]
> + (LP_SIZE*argc)(%rsp) NULL
> + (LP_SIZE*(argc+1))(%rsp) envp[0]
> ...
> - NULL
> + NULL
Fix the indentation (i.e. delete a tab) so the rhs lines up as before.
> +#ifdef __ILP32__
> + mov (%rsp),%esi /* Simulate popping 4byte argument count. */
> + addl $4,%esp
> +#else
Space after comma. Why use "addl" when the trend is to drop the size
suffices everywhere they are superfluous?
Thanks,
Roland