This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] BZ#10375: Configure magic to use -U_FORTIFY_SOURCEif needed.

> > -CPPFLAGS-config = @CPPFLAGS@
> > +CPPFLAGS-config = @CPPUNDEFS@ @CPPFLAGS@
> 
> Is there a reason to prepend this rather than append it?  Appending it
> has the advantage of fixing the build for people who have
> _FORTIFY_SOURCE defined in their default build environment CPPFLAGS
> (which this currently detects but does not fix).

My logic was simply that this automatic addition is meant to counteract the
compiler default.  So it's in the earliest position to come closest to the
predefines.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]