This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix missing _mcount@GLIBC_2.0 on powerpc32


On Wed, May 02, 2012 at 11:49:58AM +0200, Andreas Schwab wrote:
> This brings back _mcount@GLIBC_2.0 on powerpc32.

Thanks, this looks very similar to the patch I have in testing.

> 	* sysdeps/powerpc/powerpc32/old-ppc-mcount.S: New file.

Except I called this compat-ppc-mcount.S, and made the old symbol
hidden.

>  ifeq ($(subdir),gmon)
> -sysdep_routines += ppc-mcount
> +sysdep_routines += ppc-mcount old-ppc-mcount
>  static-only-routines += ppc-mcount
>  endif

Add old-ppc-mcount to shared-only-routines here, to omit an empty
object file in libc.a?

> +#ifndef SHARED
>  	bl	JUMPTARGET(__mcount_internal)
> +#else
> +	bl	__mcount_internal@local
> +#endif

That's nice, I missed this trick in my patch.

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]