This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Fix <sys/uio.h>
On Fri, Apr 13, 2012 at 2:42 PM, Ryan Arnold <rsa@us.ibm.com> wrote:
> I've regenerated this patch against the master branch and would like to
> commit it soon. ÂMany of us have been carrying this trivial patch for
> far too long.
>
> Ryan S. Arnold
> IBM Linux Technology Center
>
> 2009-11-06 ÂPetr Baudis Â<pasky@suse.cz>
>
> Â Â Â Â* include/sys/uio.h: Change __vector to __iovec to avoid clash
> Â Â Â Âwith altivec.
>
> diff --git a/include/sys/uio.h b/include/sys/uio.h
> index 0ec9ab0..7d67d67 100644
> --- a/include/sys/uio.h
> +++ b/include/sys/uio.h
> @@ -3,13 +3,13 @@
>
> Â#ifndef _ISOMAC
> Â/* Now define the internal interfaces. Â*/
> -extern ssize_t __readv (int __fd, const struct iovec *__vector,
> +extern ssize_t __readv (int __fd, const struct iovec *__iovec,
> Â Â Â Â Â Â Â Â Â Â Â Âint __count);
> -extern ssize_t __libc_readv (int __fd, const struct iovec *__vector,
> +extern ssize_t __libc_readv (int __fd, const struct iovec *__iovec,
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â int __count);
> -extern ssize_t __writev (int __fd, const struct iovec *__vector,
> +extern ssize_t __writev (int __fd, const struct iovec *__iovec,
> Â Â Â Â Â Â Â Â Â Â Â Â int __count);
> -extern ssize_t __libc_writev (int __fd, const struct iovec *__vector,
> +extern ssize_t __libc_writev (int __fd, const struct iovec *__iovec,
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âint __count);
> Â#endif
> Â#endif
Considering that I have to regenerate the patch to apply it cleanly,
I'm not sure how this should be added to the ChangeLog.
We discussed in IRC a bit and Roland seems in favor of adding it with
the existing (old) date to the top of the ChangeLog.
Carlos O'Donell seems to favor updating the date to reflect the commit date.
Consensus would be nice on this one.
Ryan