This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Unbound alloca in crypt routines
- From: "Carlos O'Donell" <carlos at systemhalted dot org>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: Jeff Law <law at redhat dot com>, libc-alpha at sources dot redhat dot com
- Date: Thu, 29 Mar 2012 13:18:53 -0400
- Subject: Re: [PATCH] Unbound alloca in crypt routines
- References: <4F74940F.1010702@redhat.com><20120329171001.09DAC2C083@topped-with-meat.com>
On Thu, Mar 29, 2012 at 1:10 PM, Roland McGrath <roland@hack.frob.com> wrote:
> The pontificating comments are inappropriate. ?The use of
> __libc_use_alloca is well established throughout the code.
> It does not require any special comment, let alone a snarky one.
I agree here.
The comments should be professional and informative.
Please update the patch.
Cheers,
Carlos.