This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[ PATCH] Fix typo in nss_getent



__nss_getent has the following code fragment:



if (*buffer == NULL) { *buffer_size = buflen; *buffer = malloc (*buffer_size); }

  while (buffer != NULL
  [ ... ]

The "buffer != NULL" clause in the WHILE statement will be eliminated as it is always true (buffer was dereferenced in the prior IF statement, thus it can't be NULL at the WHILE statement).

The original author clearly meant to test
while (*buffer != NULL
[... ]

2012-03-23 Jeff Law <law@redhat.com>

* nss/getnssent.c (__nss_getent): Fix typo.


Attachment: patch
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]